Add test coverage for ComplianceConfig #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some cases that use datetime that were causing code coverage flutuations depending on when the tests are run, fixed this by adding a date provider and new unit tests. - Related opensearch-project#3137 Signed-off-by: Peter Nied <petern@amazon.com>
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
peternied
commented
Jan 16, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
commented
Jan 16, 2024
src/test/java/org/opensearch/security/auditlog/compliance/ComplianceConfigTest.java
Show resolved
Hide resolved
peternied
changed the title
peternied
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3952 +/- ##
==========================================
+ Coverage 65.42% 65.47% +0.04%
==========================================
Files 298 298
Lines 21219 21223 +4
Branches 3457 3457
==========================================
+ Hits 13883 13896 +13
+ Misses 5616 5609 -7
+ Partials 1720 1718 -2
|
DarshitChanpura
approved these changes
Jan 17, 2024
stephen-crawford
approved these changes
Jan 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 09051f4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some cases that use datetime that were causing code coverage fluctuations depending on when the tests are run, fixed this by adding a date provider and new unit tests.
Issues Resolved
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.