Redact sensitive configuration values when retrieving security configuration #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4024 +/- ##
==========================================
+ Coverage 65.61% 65.64% +0.03%
==========================================
Files 298 298
Lines 21247 21278 +31
Branches 3457 3460 +3
==========================================
+ Hits 13941 13968 +27
- Misses 5586 5588 +2
- Partials 1720 1722 +2
|
stephen-crawford
previously approved these changes
Feb 5, 2024
There was a problem hiding this comment.
ty for adding this feature @cwperks. Could you please look into code-cov comments to see if anyone of those can be covered via more tests?
Signed-off-by: Craig Perkins <cwperx@amazon.com>
willyborankin
approved these changes
Feb 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
…uration (#4024) ### Description Redacts the field `password` when calling `GET /_plugins/_security/api/securityconfig`. Redacting the field through the API will also ensure that it doesn't get displayed on OSD. **Note**: This value would only be displayed to users with access to the security pages. <img width="471" alt="Screenshot 2024-02-05 at 3 27 34 PM" src="https://github.com/opensearch-project/security/assets/17432265/7cd93f70-9eb9-4ac2-859c-00a7bfb56718"> * Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Enhancement ### Issues Resolved - #4004 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit a41b3f7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…uration (opensearch-project#4024) ### Description Redacts the field `password` when calling `GET /_plugins/_security/api/securityconfig`. Redacting the field through the API will also ensure that it doesn't get displayed on OSD. **Note**: This value would only be displayed to users with access to the security pages. <img width="471" alt="Screenshot 2024-02-05 at 3 27 34 PM" src="https://github.com/opensearch-project/security/assets/17432265/7cd93f70-9eb9-4ac2-859c-00a7bfb56718"> * Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Enhancement ### Issues Resolved - opensearch-project#4004 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redacts the field
passwordwhen callingGET /_plugins/_security/api/securityconfig.Redacting the field through the API will also ensure that it doesn't get displayed on OSD. Note: This value would only be displayed to users with access to the security pages.
Enhancement
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.