-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude_roles
configuration parameter to LDAP authorization backend
#4025
Conversation
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4025 +/- ##
==========================================
+ Coverage 65.60% 65.84% +0.23%
==========================================
Files 298 298
Lines 21247 21258 +11
Branches 3457 3464 +7
==========================================
+ Hits 13940 13997 +57
+ Misses 5585 5527 -58
- Partials 1722 1734 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Could you please look at the codecov-patch percentage drop ?
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
src/main/java/com/amazon/dlic/auth/ldap/backend/LDAPAuthorizationBackend.java
Show resolved
Hide resolved
src/main/java/com/amazon/dlic/auth/ldap/backend/LDAPAuthorizationBackend.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Blocked by: #4026 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @cwperks !
@DarshitChanpura Code cov drop is because the tests aren't currently looking for the debug log statements as Peter mentioned here. I will follow-up with tests that hit those lines. |
okay. @cwperks Are you planning to add those in follow-up PR or this one? |
@DarshitChanpura I will follow-up with the additional tests in another PR. The LogsRule is the best way to write tests that expect logging statements, but its not available outside the |
…kend (#4025) Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com> (cherry picked from commit 0bb31ca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…thorization backend (#4043) Backport 0bb31ca from #4025. Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
…kend (opensearch-project#4025) Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Description
Based on related PR: #3809
Adds a new config value for LDAP Authorization Backend called
exclude_roles
. This config value lets a cluster administrator configure a list of roles (globs are accepted too) to exclude from an external LDAP system to limit the backend roles fetched for a user to the most pertinent roles for OpenSearch.Enhancement
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.