-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.12 update roles.yml with new API for experimental alerting plugin feature #4027
v2.12 update roles.yml with new API for experimental alerting plugin feature #4027
Conversation
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Could someone please apply the |
@AWSHurneyt Should this be added to |
@cwperks Wouldn't the |
Yes it will, disregard my comment. This LGTM. The BWC tests will start passing once #4026 is merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4027 +/- ##
=======================================
Coverage 65.60% 65.61%
=======================================
Files 298 298
Lines 21247 21278 +31
Branches 3457 3460 +3
=======================================
+ Hits 13940 13962 +22
- Misses 5585 5593 +8
- Partials 1722 1723 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AWSHurneyt Is this targeted for 2.12? if so, to unblock, the feature, would you mind creating the PR against 2.12 branch to avoid delays. The code freeze date is in the past but if this is needed I think we can still get this in with a request.
@AWSHurneyt could you run this: |
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
06480e5
Revised the PR. |
@DarshitChanpura @cwperks Manual backport to the 2.12 branch The |
…alerting plugin feature #4027 (#4029) ### Description We added a new API to the alerting plugin to support enhancements to the UI ([link](https://github.com/opensearch-project/alerting/blob/main/alerting/src/main/kotlin/org/opensearch/alerting/action/GetRemoteIndexesAction.kt#L13)). The enhancements allow users to configure per query, and per bucket monitors that can query remote clusters via the UI. Previously, such monitors could only be configured using devtools/API commands. In addition, we added support for configuring cluster metrics monitors which can execute various API ([link to full list of supported API](https://opensearch.org/docs/latest/observing-your-data/alerting/per-cluster-metrics-monitors/#supported-apis)) against remote clusters. The new API is used by the frontend to also support creating these monitors via the UI. * Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) * New experimental feature * Enhancement to existing features * Why these changes are required? * To include this API permission in the reserved role that's shipped with the default distribution of OpenSearch. * What is the old behavior before changes and new behavior after changes? * This API was not available before the experimental launch. With the experimental feature enabled, this API can be used to retrieve a list of connect remote clusters, the indexes/aliases on those clusters along with their health statuses, and optionally the mappings for those indexes. ### Issues Resolved opensearch-project/alerting-dashboards-plugin#796 Is this a backport? If so, please add backport PR # and/or commits # #4027 ### Testing Executed E2E tests with and without the experimental feature enabled to help ensure no regressions. ### Check List - [x] New functionality includes testing - [x] New functionality has been documented - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…feature (opensearch-project#4027) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Description
We added a new API to the alerting plugin to support enhancements to the UI (link). The enhancements allow users to configure per query, and per bucket monitors that can query remote clusters via the UI. Previously, such monitors could only be configured using devtools/API commands.
In addition, we added support for configuring cluster metrics monitors which can execute various API (link to full list of supported API) against remote clusters. The new API is used by the frontend to also support creating these monitors via the UI.
Issues Resolved
opensearch-project/alerting-dashboards-plugin#796
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Executed E2E tests with and without the experimental feature enabled to help ensure no regressions.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.