-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating security reachout email #4333
Conversation
Signed-off-by: Varun Lodaya <varunml@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4333 +/- ##
=======================================
Coverage 65.99% 65.99%
=======================================
Files 302 302
Lines 21758 21758
Branches 3522 3522
=======================================
Hits 14360 14360
+ Misses 5630 5629 -1
- Partials 1768 1769 +1 |
Thank you! I think this would require a change across packages- https://github.com/opensearch-project/OpenSearch/blob/main/SECURITY.md For better consistency, maybe all other package files can redirect to a single file in this or core package, thoughts? |
Yes @shikharj05, I have started on this repo but will add similar change across all repos. As for redirection, that's a good idea. The security section can be a reference to 1 common place, maybe at project level. Will wait to hear thoughts from others, @dblock ? |
@shikharj05 could you please fix DCO? (see please https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin) |
Not sure why DCO failed. The commit is signed off:
|
Oh, I see the message:
I manually set DCO to pass. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-1.x
# Create a new branch
git switch --create backport/backport-4333-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab4b3233492f352432c7c17bf16c6b47b484e65b
# Push it to GitHub
git push --set-upstream origin backport/backport-4333-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/security/backport-1.3
# Create a new branch
git switch --create backport/backport-4333-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab4b3233492f352432c7c17bf16c6b47b484e65b
# Push it to GitHub
git push --set-upstream origin backport/backport-4333-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4333-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab4b3233492f352432c7c17bf16c6b47b484e65b
# Push it to GitHub
git push --set-upstream origin backport/backport-4333-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Signed-off-by: Varun Lodaya <varunml@amazon.com> (cherry picked from commit ab4b323)
Signed-off-by: Varun Lodaya <varunml@amazon.com> (cherry picked from commit ab4b323)
Description
[Describe what this change achieves]
Updating security reach out email address from aws-security@amazon.com to security@opensearch.org.
Issues Resolved
[List any issues this PR will resolve]
N/A
Is this a backport? If so, please add backport PR # and/or commits #
N/A
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.