Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Fix #4280] Introduce new endpoint _plugins/_security/api/certificates #4355

Merged
merged 1 commit into from
May 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented May 21, 2024

Backport 382bc5f from #4299. Changed inheritance from TransportRequest to BaseNodeRequest.

cwperks
cwperks previously approved these changes May 21, 2024
willyborankin
willyborankin previously approved these changes May 21, 2024
@willyborankin
Copy link
Collaborator

willyborankin commented May 21, 2024

@cwperks there are plugin install failures. I iwll take a look. Liks like some of PRs have not been backported yet. My bad

@willyborankin
Copy link
Collaborator

willyborankin commented May 21, 2024

The PR depends on #4358

@willyborankin willyborankin force-pushed the backport/backport-4299-to-2.x branch from 197ef98 to a235088 Compare May 22, 2024 06:25
@willyborankin willyborankin dismissed stale reviews from cwperks and themself via bf6b83e May 22, 2024 07:12
@willyborankin willyborankin force-pushed the backport/backport-4299-to-2.x branch from a235088 to bf6b83e Compare May 22, 2024 07:12
#4299)

Signed-off-by: Andrey Pleskach <ples@aiven.io>
(cherry picked from commit 382bc5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@willyborankin willyborankin force-pushed the backport/backport-4299-to-2.x branch from bf6b83e to 6e18f51 Compare May 22, 2024 07:15
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 10.66667% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 65.38%. Comparing base (e8b4b3f) to head (6e18f51).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4355      +/-   ##
==========================================
- Coverage   65.97%   65.38%   -0.59%     
==========================================
  Files         301      309       +8     
  Lines       21588    21812     +224     
  Branches     3514     3543      +29     
==========================================
+ Hits        14242    14262      +20     
- Misses       5585     5786     +201     
- Partials     1761     1764       +3     
Files Coverage Δ
...security/dlic/rest/api/SecurityRestApiActions.java 80.00% <ø> (ø)
...urity/dlic/rest/api/SecuritySSLCertsApiAction.java 72.46% <100.00%> (+0.40%) ⬆️
...rity/dlic/rest/api/ssl/CertificatesActionType.java 100.00% <100.00%> (ø)
.../opensearch/security/OpenSearchSecurityPlugin.java 84.30% <50.00%> (-0.20%) ⬇️
...h/security/dlic/rest/api/ssl/CertificatesInfo.java 0.00% <0.00%> (ø)
...lic/rest/api/ssl/CertificatesInfoNodesRequest.java 0.00% <0.00%> (ø)
...ch/security/dlic/rest/api/ssl/CertificateType.java 0.00% <0.00%> (ø)
.../security/dlic/rest/api/CertificatesApiAction.java 36.11% <36.11%> (ø)
.../api/ssl/TransportCertificatesInfoNodesAction.java 10.52% <10.52%> (ø)
...ch/security/dlic/rest/api/ssl/CertificateInfo.java 0.00% <0.00%> (ø)
... and 1 more

... and 3 files with indirect coverage changes

@cwperks cwperks merged commit 7ecb37d into 2.x May 22, 2024
86 of 88 checks passed
@cwperks cwperks deleted the backport/backport-4299-to-2.x branch May 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants