Add security analytics threat intel action #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <jowg@amazon.com>
jowg-amazon
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
shikharj05
reviewed
Jun 28, 2024
shikharj05
approved these changes
Jun 28, 2024
eirsep
approved these changes
Jun 28, 2024
Signed-off-by: Joanne Wang <jowg@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4498 +/- ##
==========================================
- Coverage 65.21% 65.18% -0.04%
==========================================
Files 313 313
Lines 22047 22053 +6
Branches 3559 3561 +2
==========================================
- Hits 14378 14375 -3
- Misses 5895 5904 +9
Partials 1774 1774 |
cwperks
reviewed
Jun 29, 2024
There was a problem hiding this comment.
@jowg-amazon Is there an issue that could be linked to this change? Also, these should be added as part of the static drop-down list here.
Signed-off-by: Joanne Wang <jowg@amazon.com>
|
Please link the dashboard PR if you want it to show up in the UI, otherwise LGTM |
|
@DarshitChanpura @derek-ho I've attached a feature issue to the description above. Additionally we do not need these changes to show up in the UI. Thanks! |
cwperks
approved these changes
Jul 2, 2024
derek-ho
approved these changes
Jul 2, 2024
willyborankin
approved these changes
Jul 3, 2024
DarshitChanpura
approved these changes
Jul 3, 2024
DarshitChanpura
merged commit 20c8775
into
opensearch-project:main
41 of 42 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 20c8775) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the new api action names for security analytics threat intel project
Feature Issue: opensearch-project/security-analytics#1117
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.