-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial changes to expose an endpoint for auth failure listener get call #4641
Merged
DarshitChanpura
merged 13 commits into
opensearch-project:main
from
derek-ho:auth-failure-api
Sep 5, 2024
Merged
Add initial changes to expose an endpoint for auth failure listener get call #4641
DarshitChanpura
merged 13 commits into
opensearch-project:main
from
derek-ho:auth-failure-api
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et call Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4641 +/- ##
==========================================
+ Coverage 65.22% 65.56% +0.33%
==========================================
Files 318 319 +1
Lines 22327 22448 +121
Branches 3591 3602 +11
==========================================
+ Hits 14562 14717 +155
+ Misses 5967 5923 -44
- Partials 1798 1808 +10
|
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
3 tasks
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
August 21, 2024 20:08
shikharj05
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, few minor comments.
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiActionTest.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiActionTest.java
Outdated
Show resolved
Hide resolved
DarshitChanpura
changed the title
Add initial changes to expose an endpoint for auth failure listener g…
Add initial changes to expose an endpoint for auth failure listener get call
Aug 22, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Show resolved
Hide resolved
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Show resolved
Hide resolved
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Show resolved
Hide resolved
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 28, 2024
src/main/java/org/opensearch/security/securityconf/impl/v7/ConfigV7.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
reviewed
Aug 29, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 29, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 29, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Aug 29, 2024
src/test/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiActionTest.java
Show resolved
Hide resolved
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
reviewed
Aug 29, 2024
src/main/java/org/opensearch/security/dlic/rest/api/AuthFailureListenersApiAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <dxho@amazon.com>
cwperks
approved these changes
Aug 30, 2024
DarshitChanpura
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Feature
Creates API for GET/DELETE/CREATE auth failure listeners
Auth failure listeners could only be modified by yaml
Issues Resolved
Fix: #4614
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
Added a test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.