Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use evaluateSslExceptionHandler() when constructing OpenSearchSecureSettingsFactory #4725

Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 10, 2024

Description

While working on #4119, a minor regression related to configuring the right sslExceptionHandler sneaked in, fixing it now.

Issues Resolved

Part of #4718

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ettingsFactory

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.52%. Comparing base (2dbc508) to head (ec51813).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4725      +/-   ##
==========================================
- Coverage   65.54%   65.52%   -0.03%     
==========================================
  Files         319      319              
  Lines       22448    22448              
  Branches     3602     3602              
==========================================
- Hits        14714    14708       -6     
- Misses       5927     5929       +2     
- Partials     1807     1811       +4     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.61% <100.00%> (+0.13%) ⬆️

... and 4 files with indirect coverage changes

@willyborankin willyborankin merged commit 014c8de into opensearch-project:main Sep 10, 2024
42 of 43 checks passed
@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Sep 10, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
…ettingsFactory (#4725)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 014c8de)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta reta added v3.0.0 v2.18.0 Issues targeting release v2.18.0 labels Sep 10, 2024
tmanninger pushed a commit to tmanninger/opensearch-security that referenced this pull request Sep 24, 2024
…ettingsFactory (opensearch-project#4725)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: tmanninger <t.manninger@ixolit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch bug Something isn't working v2.18.0 Issues targeting release v2.18.0 v3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants