-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle non-flat yaml settings for demo configuration detection #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
changed the title
handle non-flat case
Handle non-flat yaml settings for demo configuration detection
Oct 8, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
October 8, 2024 17:58
DarshitChanpura
approved these changes
Oct 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4793 +/- ##
==========================================
+ Coverage 67.95% 67.98% +0.03%
==========================================
Files 310 310
Lines 20927 20938 +11
Branches 3322 3326 +4
==========================================
+ Hits 14220 14235 +15
+ Misses 4953 4948 -5
- Partials 1754 1755 +1
|
cwperks
approved these changes
Oct 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 5436146) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. Coming from: #4735, the demo config tool is not correctly detecting nested yaml for security settings when detecting whether the cluster already has security settings. This fixes it by using the SnakeYaml library to read and search for nested cases.
Issues Resolved
fix: 4735
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
Existing tests pass, added a nested path test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.