Adds a sample resource plugin to demonstrate resource access control in action #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/resource-permissions #4893 +/- ##
================================================================
+ Coverage 71.42% 71.43% +0.01%
================================================================
Files 334 334
Lines 22517 22552 +35
Branches 3586 3590 +4
================================================================
+ Hits 16082 16110 +28
- Misses 4641 4646 +5
- Partials 1794 1796 +2 |
cwperks
reviewed
Nov 11, 2024
| @@ -0,0 +1 @@ | |||
| org.opensearch.sample.SampleResourcePlugin | |||
There was a problem hiding this comment.
Is there a SPI that this file is associated with?
cwperks
reviewed
Nov 11, 2024
| protected void doExecute(Task task, ListAccessibleResourcesRequest request, ActionListener<ListAccessibleResourcesResponse> listener) { | ||
| try { | ||
| ResourceService rs = SampleResourcePlugin.GuiceHolder.getResourceService(); | ||
| List<String> resourceIds = rs.getResourceAccessControlPlugin().listAccessibleResourcesInPlugin(RESOURCE_INDEX_NAME); |
There was a problem hiding this comment.
Should we consider giving back resource objects here?
|
Is there any way we can add tests and run them as a CI check for the sample plugin? (preferably w/o relying on core-side changes bc its not clear when core-side changes can be merged) |
…in action Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
sample-resource-plugin
branch
from
543efbd to
561e294
Compare
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
sample-resource-plugin
branch
from
f43dc66 to
bfc39ad
Compare
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a sample plugin aimed at demonstrating the usage of resource access control in action. Resource access control is introduced in #4746
Issues Resolved
[TBD]
Testing
Automated + Manual
Check List
- [ ] New functionality has been documented- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR- [ ] API changes companion pull request createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.