-
Notifications
You must be signed in to change notification settings - Fork 343
[Resource Sharing] Adds API to provide dashboards support for resource access management #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cwperks
merged 36 commits into
opensearch-project:main
from
DarshitChanpura:frontend-support-resource-sharing
Sep 25, 2025
Merged
[Resource Sharing] Adds API to provide dashboards support for resource access management #5597
cwperks
merged 36 commits into
opensearch-project:main
from
DarshitChanpura:frontend-support-resource-sharing
Sep 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-sharing feature is enabled or disabled Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…index Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
58cb444 to
ba53621
Compare
3 tasks
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
… also updates tests Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
… of sharing button on front-end Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
abee804 to
b0a98e8
Compare
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
7676773 to
0a53e3d
Compare
Member
|
@DarshitChanpura can you add new API Request and Response examples to the PR description? |
cwperks
reviewed
Sep 5, 2025
cwperks
reviewed
Sep 16, 2025
src/main/java/org/opensearch/security/resources/ResourceAccessHandler.java
Outdated
Show resolved
Hide resolved
…s some variable names Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
cwperks
reviewed
Sep 22, 2025
src/main/java/org/opensearch/security/resources/ResourceSharingIndexHandler.java
Show resolved
Hide resolved
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
cwperks
reviewed
Sep 24, 2025
src/main/java/org/opensearch/security/resources/ResourceSharingIndexHandler.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Sep 24, 2025
…on-groups yml and cleans up canUserShare logic Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Member
|
…dex and updates documentations Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
cwperks
previously approved these changes
Sep 24, 2025
Member
cwperks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments have been addressed. Thank you @DarshitChanpura!
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…handle mapping update Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
25ea921 to
2f67462
Compare
…ation Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
RyanL1997
previously approved these changes
Sep 24, 2025
cwperks
approved these changes
Sep 25, 2025
RyanL1997
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
resource-permissions
Label to track all items related to resource permissions
v3.3.0
Issues targeting release v3.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for dashboard page to manage resource access. Enables plugins to supply static per-resource action-groups through yml config.
Issues Resolved
Testing
Automated + manual
1.
GET /_plugins/_security/api/resource/typesDescription:
Retrieves the current sharing configuration for a given resource.
Example Request:
Response:
{ "types": [ { "type": "org.opensearch.sample.SampleResource", "index": ".sample_resource", "action_groups": ["sample_read_only", "sample_read_write", "sample_full_access"] } ] }NOTE:
action_groupsare fetched fromresource-action-groups.ymlsupplied by resource plugin.2.
GET /_plugins/_security/api/resource/list?resource_type=<resource-index-name>Description:
Retrieves sharing information for all records accessible to requesting user for the given resource_index.
Example Request:
as user
darshitResponse:
{ "resources": [ { "resource_id": "1", "created_by": { "user": "darshit", "tenant": "some-tenant" }, "share_with": { "sample_read_only": { "users": ["craig"] } }, "can_share": true } ] }NOTE:
share_withmay not be present if resource has not been shared yetcraig,can_sharevalue for resource_id1will befalsesincecraigdoes not have share permission.Check List
- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR- [ ] API changes companion pull request createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.