Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Nov 26, 2025

Description

A new method was recently added to AccessController in core to throw the original kind of Exception being thrown by the runnable instead of a generic Exception. With disambiguation, we are able to clean up some code in this repo.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Refactoring

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Copy link
Member Author

cwperks commented Nov 26, 2025

Needs a new min distribution

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.63%. Comparing base (190b7c7) to head (f343144).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ensearch/security/ssl/DefaultSecurityKeyStore.java 40.00% 5 Missing and 1 partial ⚠️
...opensearch/security/auth/ldap/util/LdapHelper.java 0.00% 2 Missing ⚠️
...search/security/auth/ldap2/PrivilegedProvider.java 71.42% 1 Missing and 1 partial ⚠️
...auth/http/saml/SamlFilesystemMetadataResolver.java 0.00% 1 Missing ⚠️
.../org/opensearch/security/ssl/SslConfiguration.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5815      +/-   ##
==========================================
+ Coverage   73.51%   73.63%   +0.11%     
==========================================
  Files         438      438              
  Lines       26710    26644      -66     
  Branches     3956     3936      -20     
==========================================
- Hits        19637    19618      -19     
+ Misses       5195     5153      -42     
+ Partials     1878     1873       -5     
Files with missing lines Coverage Δ
...urity/auth/http/saml/SamlHTTPMetadataResolver.java 63.15% <100.00%> (+2.28%) ⬆️
...ecurity/auth/ldap2/LDAPAuthenticationBackend2.java 81.01% <100.00%> (+5.74%) ⬆️
...security/auth/ldap2/LDAPAuthorizationBackend2.java 49.21% <100.00%> (+1.12%) ⬆️
...opensearch/security/auth/ldap2/MakeJava9Happy.java 46.66% <100.00%> (+5.49%) ⬆️
...g/opensearch/security/dlic/rest/support/Utils.java 71.42% <100.00%> (+12.60%) ⬆️
...auth/http/saml/SamlFilesystemMetadataResolver.java 0.00% <0.00%> (ø)
.../org/opensearch/security/ssl/SslConfiguration.java 77.58% <0.00%> (-3.45%) ⬇️
...opensearch/security/auth/ldap/util/LdapHelper.java 83.87% <0.00%> (+9.58%) ⬆️
...search/security/auth/ldap2/PrivilegedProvider.java 54.76% <71.42%> (+4.76%) ⬆️
...ensearch/security/ssl/DefaultSecurityKeyStore.java 31.12% <40.00%> (+0.55%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cwperks cwperks merged commit bf3bb55 into opensearch-project:main Nov 26, 2025
65 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants