Improve IT coverage of all AD & Alerting tools #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
|
Only failing tests are unrelated to this PR. |
dbwiddis
approved these changes
Jan 31, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add search alert IT cases Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add more IT Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Turn off returning ad job Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add AD results IT; clean up constants Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Use sample monitor for ingestion Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 21e964c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Add search alert IT cases * Add more IT * Turn off returning ad job * Add AD results IT; clean up constants * Use sample monitor for ingestion --------- (cherry picked from commit 21e964c) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
… (opensearch-project#167) * Add search alert IT cases * Add more IT * Turn off returning ad job * Add AD results IT; clean up constants * Use sample monitor for ingestion --------- (cherry picked from commit 21e964c) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds much more comprehensive integration test coverage of the AD and alerting tools by adding more test cases, actual execution of more REST API calls, persisting system index mappings and actual sample resources, and deeper checks on the input parameters and returned fields.
Also includes 2 minor improvements on the
SearchAnomalyDetectorsTool:falseon thereturnAdJobwhen making the get detector profile transport call. This fixes the edge case of running into NPEs if a detector has no existing job / has never been startedIssues Resolved
Closes #136
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.