CreateAnomalyDetectorTool supports empty model_type #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gaobinlong <gbinlong@amazon.com>
gaobinlong
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
|
Flakey tests coming from RAG Tool IT. Can @mingshl take a look? |
|
@gaobinlong Can you check the comment here #452 (comment)? You can update the PR after Heng's PR gets merged. |
zane-neo
reviewed
Nov 14, 2024
zane-neo
approved these changes
Nov 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* CreateAnomalyDetectorTool supports empty model_type Signed-off-by: gaobinlong <gbinlong@amazon.com> * Optimize code Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add some comment Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit cfc88d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5 tasks
zane-neo
added a commit
that referenced
this pull request
Nov 14, 2024
* CreateAnomalyDetectorTool supports empty model_type * Optimize code * Add some comment --------- (cherry picked from commit cfc88d8) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zane-neo <zaniu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same to the PPLTool, CreateAnomalyDetectorTool should also support empty model_type parameter, rather than throwing an
IllegalArgumentException, we need to make the behavior consistent between the tools.Related Issues
No issue.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.