Migrate alerting tools #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
============================================
+ Coverage 81.76% 82.21% +0.44%
- Complexity 63 119 +56
============================================
Files 6 10 +4
Lines 373 686 +313
Branches 46 94 +48
============================================
+ Hits 305 564 +259
- Misses 38 74 +36
- Partials 30 48 +18 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 26, 2023
dbwiddis
reviewed
Dec 26, 2023
| @@ -12,6 +12,7 @@ buildscript { | |||
| opensearch_version = System.getProperty("opensearch.version", "3.0.0-SNAPSHOT") | |||
| isSnapshot = "true" == System.getProperty("build.snapshot", "true") | |||
| buildVersionQualifier = System.getProperty("build.version_qualifier", "") | |||
| kotlin_version = System.getProperty("kotlin.version", "1.8.21") | |||
There was a problem hiding this comment.
I'm using the same as that of common utils which has the AlertingPluginInterface logic we use here.
src/main/java/org/opensearch/agent/tools/SearchMonitorsTool.java
Outdated
Show resolved
Hide resolved
dhrubo-os
reviewed
Dec 26, 2023
| sb.append("id=").append(monitor.getId()).append(","); | ||
| sb.append("name=").append(monitor.getName()); | ||
| sb.append("}]"); | ||
| sb.append("TotalMonitors=1"); |
There was a problem hiding this comment.
will that be 1 all the time? What if we find 2/3 monitors?
There was a problem hiding this comment.
This will be 1 all of the time since it is a GetMonitorResponse: https://opensearch.org/docs/latest/observing-your-data/alerting/api/#get-monitor
There was a problem hiding this comment.
See comment on line 93/94 above as well.
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
zane-neo
reviewed
Dec 27, 2023
zane-neo
approved these changes
Dec 27, 2023
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
|
|
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
* Add search alerts tool Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add search monitors tool Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add param tests and number parsing error handling Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add for list-based params Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add error logs Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Fix isNumeric var Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Minor test coverage increase & cleanup Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Cover few edge cases when param parsing Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 2f06f6f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Dec 28, 2023
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
(cherry picked from commit 2f06f6f) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the search alerts and search monitors tools to this repo.
Historical PRs:
opensearch-project/ml-commons#1748
opensearch-project/ml-commons#1749
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.