Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ApplicationContext lifecycle to per node level #822

Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Sep 13, 2022

Signed-off-by: penghuo penghuo@gmail.com

Description

  1. Currently, ApplicationContext is constructed per request. In this PR. we refactor the ApplicationContext lifecycle to per node level.
  2. We change the bean scope to prototype to create PPLService/SQLService per request.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo penghuo requested a review from a team as a code owner September 13, 2022 15:59
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants