Fix incorrect results returned by min, max and avg

[Yury-Fridlyand]

Fix incorrect results returned by min, max and avg when processing null/missing values only.

Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com

See team review & discussion in Bit-Quill#145

Description

Before

opensearchsql> select min(int0) from calcs where int0 IS NULL;
fetched rows / total rows = 1/1
+-------------+
| min(int0)   |
|-------------|
| 2147483647  |
+-------------+

After

opensearchsql> select min(int0) from calcs where int0 IS NULL;
fetched rows / total rows = 1/1
+-------------+
| min(int0)   |
|-------------|
| null        |
+-------------+

Fixed:

• min
• max
• avg

Not fixed:

• sum

opensearchsql> select sum(int0) from calcs where int0 IS NULL;
fetched rows / total rows = 1/1
+-------------+
| sum(int0)   |
|-------------|
| 0           |
+-------------+

mysql> select sum(int0) from calcs where int0 IS NULL;

+-----------+
| sum(int0) |
+-----------+
|      NULL |
+-----------+
1 row in set (0.00 sec)

This requires much more changes.

Not affected

• var_samp
• var_pop
• stddev_samp
• stddev_pop

Issues Resolved

Fixes #817

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (bfad32c) to head (7d60f22).
Report is 518 commits behind head on 2.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #1000      +/-   ##
============================================
- Coverage     97.95%   97.60%   -0.35%     
- Complexity     3137     3186      +49     
============================================
  Files           303      308       +5     
  Lines          7783     7983     +200     
  Branches        501      520      +19     
============================================
+ Hits           7624     7792     +168     
- Misses          158      190      +32     
  Partials          1        1              

Flag	Coverage Δ
sql-engine	97.60% <100.00%> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[penghuo]

Thanks.

[dai-chen]

The CodeQL is failing and seems caused by some regular expression in GrokUtils. I assume it's introduced by other PR earlier? https://github.com/opensearch-project/sql/pull/1000/checks?check_run_id=9215922956

[Yury-Fridlyand]

The CodeQL is failing and seems caused by some regular expression in GrokUtils. I assume it's introduced by other PR earlier? https://github.com/opensearch-project/sql/pull/1000/checks?check_run_id=9215922956

Yes, see #889, introduced in #813.

[dai-chen]

The CodeQL is failing and seems caused by some regular expression in GrokUtils. I assume it's introduced by other PR earlier? https://github.com/opensearch-project/sql/pull/1000/checks?check_run_id=9215922956

Yes, see #889, introduced in #813.

I see. Not sure why it doesn't fail on all other PRs.

Btw, to follow the same procedure, should we choose 2.x branch as target and label with backport 2.4

The base branch was changed.

[Yury-Fridlyand]

Done. Please, re-review.

[dai-chen]

Done. Please, re-review.

Looks good. Thanks!