Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable loading ML-commons plugin for doctests #1011

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Disable loading ML-commons plugin for doctests #1011

merged 1 commit into from
Nov 3, 2022

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com

Description

[temporary] Disable doctests which use ML-common plugin.

Issues Resolved

#915 (comment)
Unblocks #999

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand
Disable loading ML-commons plugin for doctests and corresponding te…
91b010d 
…sts.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner November 2, 2022 21:38
This was referenced Nov 2, 2022
Merged
Closed
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Nov 2, 2022
dai-chen
dai-chen approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Could you open an issue to remind us to bring this back once AD team improves it from their side?

@acarbonetto acarbonetto mentioned this pull request Nov 3, 2022
Open
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Nov 3, 2022
Open
@Yury-Fridlyand
Copy link
Collaborator Author

Thanks for fixing this! Could you open an issue to remind us to bring this back once AD team improves it from their side?

#1013

penghuo
penghuo approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dai-chen dai-chen merged commit 1a52511 into opensearch-project:2.x Nov 3, 2022
dai-chen pushed a commit that referenced this pull request Nov 3, 2022
@Yury-Fridlyand @dai-chen
Disable loading ML-commons plugin for doctests and corresponding te…
9da6a53 
…sts. (#1011)

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand deleted the dev-deactivate-ml-doctests branch November 16, 2022 00:35
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 7, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-chen dai-chen dai-chen approved these changes

@penghuo penghuo penghuo approved these changes

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @penghuo @dai-chen