Add valueOf() to Expression #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1055 +/- ##
============================================
- Coverage 98.27% 95.71% -2.57%
- Complexity 3344 3351 +7
============================================
Files 326 337 +11
Lines 8443 9115 +672
Branches 553 672 +119
============================================
+ Hits 8297 8724 +427
- Misses 142 334 +192
- Partials 4 57 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yury-Fridlyand
previously approved these changes
Nov 9, 2022
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
dismissed stale reviews from Yury-Fridlyand and derek-ho
via
f479a60
Thanks, i forgot i git ignored /prometheus directory.. updated PR |
Yury-Fridlyand
approved these changes
Nov 9, 2022
vmmusings
approved these changes
Nov 9, 2022
dai-chen
approved these changes
Nov 9, 2022
dai-chen
added a commit
that referenced
this pull request
Nov 9, 2022
* Fix `FLOAT` -> `DOUBLE` cast. (#1025) Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix error messaging from prometheus. (#1029) (#1037) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 4a9cef3) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> * Add `query` function as alternate syntax to `query_string` function (#1010) This maintains backwards compatibility with the v1 engine. * Update DATE and TIME functions to parse string input as datetime (#991) Add option to accept datetime like string in both TIME and DATE (eg. accept "1999-01-02 12:12:12" for both TIME and DATE. Strict check on date for testing for valid dates (eg. Don't accept Feb 30th as a valid date) and throws a SemanticCheckException. Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> * back quote fix (#1041) (#1050) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit d3bb902) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> * Catalog to Datasource changes (#1027) (#1049) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 3e30379) * Bump jackson to 2.14.0 (#1058) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 5a1adb2) * Add valueOf() to Expression (#1055) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Chen Dai <daichen@amazon.com> Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: GabeFernandez310 <64448015+GabeFernandez310@users.noreply.github.com> Co-authored-by: MitchellGale-BitQuill <104795536+MitchellGale-BitQuill@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>
vmmusings
pushed a commit
to vmmusings/sql
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vmmusings
pushed a commit
to vmmusings/sql
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li joshuali925@gmail.com
Description
Minor change to use
valueOf()instead ofvalueOf(null)Issues Resolved
closes #976
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.