Fix history file usage in SQL CLI tool. #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Fix history file usage in SQL CLI tool.
Codecov Report
@@ Coverage Diff @@
## 2.x #1077 +/- ##
============================================
- Coverage 98.27% 95.71% -2.57%
Complexity 3351 3351
============================================
Files 327 337 +10
Lines 8457 9115 +658
Branches 553 672 +119
============================================
+ Hits 8311 8724 +413
- Misses 142 334 +192
- Partials 4 57 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuali925
previously approved these changes
Nov 15, 2022
derek-ho
reviewed
Nov 16, 2022
| @@ -57,9 +61,21 @@ def __init__(self, clirc_file=None, always_use_pager=False, use_aws_authenticati | |||
| self.multiline_continuation_char = config["main"]["multiline_continuation_char"] | |||
| self.multi_line = config["main"].as_bool("multi_line") | |||
| self.multiline_mode = config["main"].get("multi_line_mode", "src") | |||
| self.history_file = config["main"]["history_file"] | |||
| self.log_file = config["main"]["log_file"] | |||
There was a problem hiding this comment.
where is this being used?
There was a problem hiding this comment.
History file used for history, log file - for logging errors. For example, if config has incorrect path to the history file.
There was a problem hiding this comment.
Got it - do you need to pass this in anywhere like you do the history file?
There was a problem hiding this comment.
No actually. Good point, thank you. self.log_file removed in f79e5a9.
Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand yuryf@bitquilltech.com
Description
Changes include:
FileHistory.history_fileandlog_fileparameters from config.Config location:
~/.config/opensearchsql-cli/configDefault location for saving history and log files:
~/.config/opensearchsql-cliInspired by: https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/examples/prompts/history/persistent-history.py
See team review at Bit-Quill#155
Test
venv(see instructions below)How to test
Ref: https://github.com/opensearch-project/sql/blob/2.x/sql-cli/development_guide.md#development-environment-set-up
Do once:
Then every time you want to debug SQL CLI:
To exit from
venv:You can run SQL CLI and switch branch. It will keep working with given timeout until closed.
Issues Resolved
Query history didn't persist across SQL CLI runs.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.