-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Day_Of_Year Function To OpenSearch #1128
Add Day_Of_Year Function To OpenSearch #1128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com>
38e3408
a76edcf
to
38e3408
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #1128 +/- ##
============================================
- Coverage 98.30% 95.79% -2.51%
- Complexity 3470 3471 +1
============================================
Files 348 358 +10
Lines 8659 9320 +661
Branches 549 668 +119
============================================
+ Hits 8512 8928 +416
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Description
Adds the
day_of_year
function to the SQL plugin. It behaves like thedayofyear
function which already exists in the new engine, and both are aligned with MySQL*Note: This function does not currently support the
TIME
type because adding support for this is currently blocked by PR 1047. This will be accomplished in future work.Issues Resolved
#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.