Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LIKE operator case-insensitive match #1160

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Dec 12, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

  1. Change LIKE operator PATTERN to case-insensitive.
  2. Update docs for SQL and PPL.

Issues Resolved

#1156

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #1160 (6146db6) into 2.x (c5e8fc0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.x    #1160   +/-   ##
=========================================
  Coverage     98.31%   98.31%           
  Complexity     3521     3521           
=========================================
  Files           342      342           
  Lines          8700     8701    +1     
  Branches        554      554           
=========================================
+ Hits           8553     8554    +1     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/opensearch/sql/utils/OperatorUtils.java 100.00% <100.00%> (ø)
...search/storage/script/filter/lucene/LikeQuery.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo marked this pull request as ready for review December 12, 2022 22:23
@penghuo penghuo requested a review from a team as a code owner December 12, 2022 22:23
@penghuo penghuo added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 12, 2022
@penghuo penghuo changed the title change case-insensitive to false Change LIKE operator case-insensitive match Dec 12, 2022
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@penghuo penghuo merged commit f8fbef7 into opensearch-project:2.x Dec 12, 2022
YANG-DB added a commit to YANG-DB/sql that referenced this pull request Dec 12, 2022
Change LIKE operator case-insensitive match (opensearch-project#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants