Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adding UTC_DATE, UTC_TIME, UTC_TIMESTAMP #1198

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 94b6bec from #1193

* Updated UTC TIME Functions for like now FunctionProperties.

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>

* Finished updates to tests.

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>

* Removed unused import.

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>

* Addressed PR comments.

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>

* Removed extra import.

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>

* removed `DateTimeFunction` used within class.

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>

Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com>
(cherry picked from commit 94b6bec)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 20, 2022 19:18
@codecov-commenter
Copy link

Codecov Report

Merging #1198 (1852c7c) into 2.x (7edc72e) will decrease coverage by 35.55%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x    #1198       +/-   ##
=============================================
- Coverage     98.31%   62.76%   -35.56%     
=============================================
  Files           346       10      -336     
  Lines          8737      658     -8079     
  Branches        555      119      -436     
=============================================
- Hits           8590      413     -8177     
- Misses          142      192       +50     
- Partials          5       53       +48     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...arch/sql/expression/datetime/DateTimeFunction.java
...h/sql/expression/function/BuiltinFunctionName.java
...ava/org/opensearch/sql/data/type/ExprCoreType.java
...pensearch/sql/storage/write/TableWriteBuilder.java
.../storage/script/filter/ExpressionFilterScript.java
...rch/sql/executor/execution/StreamingQueryPlan.java
...arch/storage/system/OpenSearchSystemIndexScan.java
...search/sql/expression/datetime/CalendarLookup.java
...n/java/org/opensearch/sql/utils/OperatorUtils.java
... and 346 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the enhancement New feature or request label Dec 20, 2022
@dai-chen dai-chen merged commit 13474e3 into 2.x Dec 22, 2022
@github-actions github-actions bot deleted the backport/backport-1193-to-2.x branch December 22, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants