Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix truncate() function #1213

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7714819 from #1197

* Fix truncate() function (#188)

Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
(cherry picked from commit 7714819)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 3, 2023 17:49
@codecov-commenter
Copy link

Codecov Report

Merging #1213 (e14cca1) into 2.x (13474e3) will decrease coverage by 35.55%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x    #1213       +/-   ##
=============================================
- Coverage     98.32%   62.76%   -35.56%     
=============================================
  Files           346       10      -336     
  Lines          8760      658     -8102     
  Branches        555      119      -436     
=============================================
- Hits           8613      413     -8200     
- Misses          142      192       +50     
- Partials          5       53       +48     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/sql/expression/function/OpenSearchFunctions.java
...expression/function/RelevanceFunctionResolver.java
...ssion/operator/arthmetic/MathematicalFunction.java
...ript/filter/lucene/relevance/SingleFieldQuery.java
...pensearch/sql/ppl/parser/AstExpressionBuilder.java
...java/org/opensearch/sql/sql/parser/AstBuilder.java
...pensearch/sql/sql/parser/AstExpressionBuilder.java
...ensearch/sql/expression/function/FunctionName.java
...org/opensearch/sql/data/type/WideningTypeRule.java
...nsearch/storage/script/ExpressionScriptEngine.java
... and 346 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the bug Something isn't working label Jan 3, 2023
@dai-chen dai-chen merged commit d7825f4 into 2.x Jan 3, 2023
@github-actions github-actions bot deleted the backport/backport-1197-to-2.x branch January 3, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants