Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable concat() string function to support multiple string arguments #1297

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 45fc371 from #1279

#1279)

* Enable `concat()` string function to support multiple string arguments (#200)

Signed-off-by: Margarit Hakobyan <margarit.hakobyan@improving.com>
(cherry picked from commit 45fc371)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 27, 2023 18:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #1297 (45fc371) into 2.x (982d366) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 45fc371 differs from pull request most recent head 9d46d4f. Consider uploading reports for the commit 9d46d4f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x    #1297   +/-   ##
=========================================
  Coverage     98.35%   98.35%           
- Complexity     3622     3627    +5     
=========================================
  Files           345      343    -2     
  Lines          8933     8951   +18     
  Branches        569      578    +9     
=========================================
+ Hits           8786     8804   +18     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...expression/function/RelevanceFunctionResolver.java 100.00% <ø> (ø)
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...g/opensearch/sql/data/model/AbstractExprValue.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprDateValue.java 100.00% <100.00%> (ø)
...g/opensearch/sql/data/model/ExprDatetimeValue.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <100.00%> (ø)
.../opensearch/sql/data/model/ExprTimestampValue.java 100.00% <100.00%> (ø)
.../java/org/opensearch/sql/data/model/ExprValue.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/data/model/ExprValueUtils.java 100.00% <100.00%> (ø)
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the enhancement New feature or request label Jan 27, 2023
@dai-chen dai-chen merged commit b62c55c into 2.x Jan 27, 2023
@github-actions github-actions bot deleted the backport/backport-1279-to-2.x branch January 27, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants