Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Datetime aggregation fixes. #1312

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5220a98 from #1061

* Update aggregation to support datetime types.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 5220a98)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 31, 2023 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #1312 (71346f6) into 2.x (b62c55c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #1312      +/-   ##
============================================
+ Coverage     98.35%   98.37%   +0.01%     
- Complexity     3632     3645      +13     
============================================
  Files           345      345              
  Lines          8957     9022      +65     
  Branches        578      585       +7     
============================================
+ Hits           8810     8875      +65     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.37% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/opensearch/sql/data/model/ExprValueUtils.java 100.00% <ø> (ø)
...sql/expression/aggregation/AggregatorFunction.java 100.00% <100.00%> (ø)
...arch/sql/expression/aggregation/AvgAggregator.java 100.00% <100.00%> (ø)
...cript/aggregation/ExpressionAggregationScript.java 100.00% <100.00%> (ø)
...ript/aggregation/dsl/BucketAggregationBuilder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the bug Something isn't working label Feb 1, 2023
@dai-chen dai-chen merged commit d6a00a8 into 2.x Feb 1, 2023
@github-actions github-actions bot deleted the backport/backport-1061-to-2.x branch February 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants