Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update TIMESTAMP function implementation and signatures. #1340

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ecb9dec from #1254

* Update `TIMESTAMP` function implementation and signatures.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Simplify `TIMESTAMP` function implementation by using automatic datetime types cast (PR #1196).

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Checkstyle fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit ecb9dec)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner February 15, 2023 00:12
@dai-chen dai-chen added the enhancement New feature or request label Feb 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #1340 (b2b9de8) into 2.x (0b10136) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #1340      +/-   ##
============================================
- Coverage     98.37%   98.37%   -0.01%     
- Complexity     3645     3649       +4     
============================================
  Files           345      345              
  Lines          9022     9019       -3     
  Branches        585      585              
============================================
- Hits           8875     8872       -3     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/opensearch/sql/data/model/ExprValueUtils.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...search/sql/expression/datetime/IntervalClause.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen merged commit 3752fd9 into 2.x Feb 15, 2023
@github-actions github-actions bot deleted the backport/backport-1254-to-2.x branch February 15, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants