Replace non-ASCII characters in code and docs. #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKsyunz
reviewed
Feb 22, 2023
common/src/test/java/org/opensearch/sql/common/grok/BasicTest.java
Outdated
Show resolved
Hide resolved
common/src/test/java/org/opensearch/sql/common/grok/BasicTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1365 +/- ##
=========================================
Coverage 98.38% 98.38%
- Complexity 3693 3694 +1
=========================================
Files 343 343
Lines 9107 9113 +6
Branches 585 586 +1
=========================================
+ Hits 8960 8966 +6
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MaxKsyunz
previously approved these changes
Feb 22, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
force-pushed
the
fix-ci-on-jenkins
branch
from
55182bf to
e21269a
Compare
|
Rebased |
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MaxKsyunz
approved these changes
Mar 8, 2023
|
may need to merge main to fix BWC test? |
I think this doesn't help. BWC in GHA environment runs on Linux and it is not sensitive for Unicode characters. Jenkins CI runs on Windows and fails. |
acarbonetto
approved these changes
Mar 21, 2023
GabeFernandez310
approved these changes
Mar 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Replace non-ASCII characters in code and docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Recover unicode characters in grok tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Removed some non-English comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Remove non-English comments from ITs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 23cc0f6)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
* Replace non-ASCII characters in code and docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Recover unicode characters in grok tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Removed some non-English comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Remove non-English comments from ITs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 23cc0f6)
Yury-Fridlyand
added a commit
that referenced
this pull request
Mar 30, 2023
* Replace non-ASCII characters in code and docs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Recover unicode characters in grok tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Removed some non-English comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Remove non-English comments from ITs. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 23cc0f6) Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace non-ASCII characters in code and docs.
Characters left:
and
°(temperature degree symbol) in IT sample data:UPD
Removed all non-English comments from legacy engine
Issues Resolved
Fixes #1364
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.