Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Deprecated Spring IoC and using Guice instead (#1177) #1410

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Backport 2.x] Deprecated Spring IoC and using Guice instead (#1177) #1410

merged 1 commit into from
Mar 8, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Mar 8, 2023 •
edited
Loading

Backport #1177

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo
Deprecated Spring IoC and using Guice instead (opensearch-project#1177)
b35a16e 
* Deprecated Spring IoC and using Guice instead

Signed-off-by: Peng Huo <penghuo@gmail.com>

* fix checkstyle issue

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Pass injector to action

Signed-off-by: Peng Huo <penghuo@gmail.com>

* update

Signed-off-by: Peng Huo <penghuo@gmail.com>

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 0a02009)
@penghuo penghuo requested a review from a team as a code owner March 8, 2023 03:12
@dai-chen dai-chen added the maintenance Improves code quality, but not the product label Mar 8, 2023
@penghuo penghuo merged commit fcce603 into opensearch-project:2.x Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmmusings vmmusings vmmusings approved these changes

@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes

@dai-chen dai-chen dai-chen approved these changes

Assignees
No one assigned
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@penghuo @dai-chen @MaxKsyunz @vmmusings