-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create datasource API #1427
Create datasource API #1427
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #1427 +/- ##
============================================
- Coverage 98.38% 96.22% -2.17%
+ Complexity 3699 1417 -2282
============================================
Files 343 152 -191
Lines 9123 3864 -5259
Branches 586 277 -309
============================================
- Hits 8976 3718 -5258
+ Misses 142 141 -1
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 191 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7e1ff62
to
f893785
Compare
9ba491c
to
6d18aeb
Compare
e3bd2f5
to
4bf8e64
Compare
Any special reason this has to merge to 2.x first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some high level questions because this PR seems have more influence than it looks:
- There is no issue related to this main feature. I think we should create something and put it to our 2.7 or roadmap
- The new
.ql-data-sources
index is shifting stateless SQL plugin to stateful? If the index is red for some reason, want to confirm if SQL plugin still work as before? At lease for query on default OpenSearch data source. - Data source related code and dependencies keep growing, should we move all of them to a new
datasource
module. Because as I understand,core
only depends on resolvedDataSource
orTable
actually.
core/src/main/java/org/opensearch/sql/datasource/DataSourceUserRoleHelper.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/datasource/model/DataSourceType.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/datasource/DataSourceAPIsIT.java
Show resolved
Hide resolved
.../src/main/java/org/opensearch/sql/plugin/datasource/OpenSearchDataSourceMetadataStorage.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/opensearch/sql/plugin/model/CreateDataSourceActionRequest.java
Outdated
Show resolved
Hide resolved
I need this for pen testing on 2.7 version. I will resolve conflicts with main branch and will soon raise a PR. Following main -> 2.x -> 1.x is becoming little difficult as we mostly test and verify against the next minor version in current running major. |
I will add all the required issues.
It should work for queries on default Opensearch Connector even in case of red
I was thinking on similar lines whether this code is really required in core or some other place. will discuss with you and try to move this. |
a08550e
to
2747293
Compare
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Please always merge to main first. If there is any blocker, we can discuss. For pen testing, you can use feature branch also. |
Description
This PR covers Create datasource REST API.
Create datasource [REST API]
Get datasource along with storage engine and other artifacts [Internal use case only]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.