Refactoring datasource changes to a new module. #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vmmusings
requested review from
anirudha,
penghuo,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Yury-Fridlyand and
MaxKsyunz
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1504 +/- ##
============================================
- Coverage 98.47% 97.09% -1.39%
- Complexity 3886 3970 +84
============================================
Files 347 368 +21
Lines 9649 10123 +474
Branches 625 651 +26
============================================
+ Hits 9502 9829 +327
- Misses 142 287 +145
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This is an excellent addition to create the datasource module !! |
YANG-DB
previously approved these changes
Apr 7, 2023
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vmmusings
force-pushed
the
ref
branch
7 times, most recently
from
a1e11ec to
6a6542b
Compare
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
penghuo
approved these changes
Apr 10, 2023
5 tasks
rupal-bq
approved these changes
Apr 10, 2023
joshuali925
approved these changes
Apr 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Reafactor into new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Refactored all the datasource releated code to new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * More unit tests Signed-off-by: vamsi-amazon <reddyvam@amazon.com> --------- Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 7584f79)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Reafactor into new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Refactored all the datasource releated code to new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * More unit tests Signed-off-by: vamsi-amazon <reddyvam@amazon.com> --------- Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 7584f79)
vmmusings
added a commit
that referenced
this pull request
Apr 14, 2023
* Reafactor into new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Refactored all the datasource releated code to new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * More unit tests Signed-off-by: vamsi-amazon <reddyvam@amazon.com> --------- Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 7584f79) Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
vmmusings
added a commit
that referenced
this pull request
Apr 14, 2023
* Reafactor into new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Refactored all the datasource releated code to new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * More unit tests Signed-off-by: vamsi-amazon <reddyvam@amazon.com> --------- Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit 7584f79) Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
acarbonetto
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Apr 18, 2023
) * Reafactor into new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * Refactored all the datasource releated code to new datasources module Signed-off-by: vamsi-amazon <reddyvam@amazon.com> * More unit tests Signed-off-by: vamsi-amazon <reddyvam@amazon.com> --------- Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.