-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doctest fix in protocol #1662
Merged
acarbonetto
merged 2 commits into
opensearch-project:main
from
Bit-Quill:Integ-fixDocTestProtocol
May 26, 2023
Merged
Doctest fix in protocol #1662
acarbonetto
merged 2 commits into
opensearch-project:main
from
Bit-Quill:Integ-fixDocTestProtocol
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Doctest fix for protocol.rst for update of PPL query error message
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
May 26, 2023 17:14
Yury-Fridlyand
approved these changes
May 26, 2023
GumpacG
approved these changes
May 26, 2023
acarbonetto
approved these changes
May 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #1662 +/- ##
=========================================
Coverage 97.16% 97.16%
Complexity 4120 4120
=========================================
Files 371 371
Lines 10373 10373
Branches 704 704
=========================================
Hits 10079 10079
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
forestmvey
approved these changes
May 26, 2023
matthewryanwells
approved these changes
May 26, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…oject#1662) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…oject#1662) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit a924d5a)
MaxKsyunz
pushed a commit
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit a924d5a)
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 10, 2023
…oject#1662) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit a924d5a) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
penghuo
pushed a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes error in
protocol.rst
test.Old:
New:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.