-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow backtick around fields in sort cmd #1688
Merged
dai-chen
merged 4 commits into
opensearch-project:main
from
joshuali925:allow-backtick-in-sort
May 31, 2023
Merged
Allow backtick around fields in sort cmd #1688
dai-chen
merged 4 commits into
opensearch-project:main
from
joshuali925:allow-backtick-in-sort
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
force-pushed
the
allow-backtick-in-sort
branch
from
May 30, 2023 23:15
52711d0
to
c8d1737
Compare
Codecov Report
@@ Coverage Diff @@
## main #1688 +/- ##
=========================================
Coverage 97.27% 97.27%
Complexity 4330 4330
=========================================
Files 388 388
Lines 10807 10807
Branches 761 761
=========================================
Hits 10513 10513
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
May 30, 2023 23:42
Yury-Fridlyand
approved these changes
May 30, 2023
dai-chen
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 31, 2023
* Allow backtick around fields in sort cmd Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add test Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update test setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * revert ignoring sql-cli repo if exists Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 691012d)
dai-chen
pushed a commit
that referenced
this pull request
May 31, 2023
* Allow backtick around fields in sort cmd Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add test Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update test setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * revert ignoring sql-cli repo if exists Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 691012d) Co-authored-by: Joshua Li <joshuali925@gmail.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
* Allow backtick around fields in sort cmd Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add test Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update test setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * revert ignoring sql-cli repo if exists Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
* Allow backtick around fields in sort cmd Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add test Signed-off-by: Joshua Li <joshuali925@gmail.com> * Update test setup Signed-off-by: Joshua Li <joshuali925@gmail.com> * revert ignoring sql-cli repo if exists Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently this doesn't work
The PR will add support for fields in backticks so
sort
behavior is consistent with other commands.This PR also fixes some build issues
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.