Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix CSV/RAW output header being application/json rather than plain/text #1795

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1ec696d from #1779

…xt (#1779)

* Fix CI (#1760)

* Fix ML-commons missing dependency.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Fix `mockito` dependency.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Revert changes in `:opensearch` since it is not needed anymore.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Fix CSV/RAW outputting wrong format (#279)

* Fixed bug where CSV/RAW outputs as JSON rather than plain text

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 1ec696d)
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (2.x@e9a009b). Click here to learn what that means.
The diff coverage is 100.00%.

@@          Coverage Diff           @@
##             2.x    #1795   +/-   ##
======================================
  Coverage       ?   97.34%           
  Complexity     ?     4411           
======================================
  Files          ?      388           
  Lines          ?    10942           
  Branches       ?      773           
======================================
  Hits           ?    10651           
  Misses         ?      284           
  Partials       ?        7           
Flag Coverage Δ
sql-engine 97.34% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rotocol/response/format/FlatResponseFormatter.java 100.00% <100.00%> (ø)
...rotocol/response/format/JsonResponseFormatter.java 100.00% <100.00%> (ø)

@Yury-Fridlyand
Copy link
Collaborator

Superseded by #1796

@Yury-Fridlyand Yury-Fridlyand deleted the backport/backport-1779-to-2.x branch June 28, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants