Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Keep up with refactoring in OpenSearch. #1802

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3fc11a4 from #1588

@acarbonetto
Copy link
Collaborator

opensearch-project/OpenSearch#8316 merged to 2.x branch

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1802 (1bac451) into 2.x (63e317b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.x    #1802   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity     4443     4443           
=========================================
  Files           388      388           
  Lines         10996    10997    +1     
  Branches        784      784           
=========================================
+ Hits          10705    10706    +1     
  Misses          284      284           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <100.00%> (ø)
...ch/sql/opensearch/client/OpenSearchRestClient.java 100.00% <100.00%> (ø)

Copy link

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for backporting. DCO carnage needs fixing OTW LGTM

@acarbonetto
Copy link
Collaborator

@nknize can you add backport 2.x label to opensearch-project/ml-commons#901 (comment)?
This PR will get blocked by their backport.

* Keep up with refactoring in OpenSearch.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

* Updating code formatting.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>

---------

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
(cherry picked from commit 3fc11a4)
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@MaxKsyunz MaxKsyunz force-pushed the backport/backport-1588-to-2.x branch from bdf254a to 1bac451 Compare July 5, 2023 17:55
@Yury-Fridlyand Yury-Fridlyand merged commit babbe90 into 2.x Jul 5, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport/backport-1588-to-2.x branch July 5, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants