Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flakytest when tests.locale=tr #1827

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix flakytest when tests.locale=tr #1827

merged 1 commit into from
Jul 11, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Jul 10, 2023 •
edited
Loading

Description

  • Fix flaktest found in IT when -Dtests.locale=tr.
  • Failed IT.
./gradlew ':integ-test:integTest' --tests "org.opensearch.sql.ppl.StandaloneIT.testSourceFieldQuery" -Dtests.seed=8DBF6CCDC4AAC1CC -Dtests.security.manager=false -Dtests.locale=tr -Dtests.timezone=Pacific/Marquesas -Druntime.java=11

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo
fix flakytest when tests.locale=tr
837d3ab 
Signed-off-by: Peng Huo <penghuo@gmail.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #1827 (837d3ab) into main (f38ffed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1827   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
  Complexity     4490     4490           
=========================================
  Files           394      394           
  Lines         11119    11119           
  Branches        795      795           
=========================================
  Hits          10823    10823           
  Misses          289      289           
  Partials          7        7
Flag Coverage Δ
sql-engine 97.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/sql/protocol/response/QueryResult.java 100.00% <100.00%> (ø)

@penghuo penghuo marked this pull request as ready for review July 10, 2023 22:44
Yury-Fridlyand
Yury-Fridlyand approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it fix #1590 and #1275? Can you add IT or UT?

@Yury-Fridlyand
Copy link
Collaborator

Reminder: backport to 2.x when CI issues resolved on 2.x branch.

@MaxKsyunz MaxKsyunz merged commit 4178c03 into opensearch-project:main Jul 11, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 11, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@penghuo @github-actions
fix flakytest when tests.locale=tr (#1827)
6e7a3cd 
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 4178c03)
penghuo added a commit that referenced this pull request Jul 11, 2023
@opensearch-trigger-bot @penghuo
fix flakytest when tests.locale=tr (#1827) (#1833)
2b8e53a 
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 4178c03)

Co-authored-by: Peng Huo <penghuo@gmail.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 11, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@penghuo @github-actions
fix flakytest when tests.locale=tr (#1827)
5224898 
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 4178c03)
penghuo added a commit that referenced this pull request Jul 11, 2023
@opensearch-trigger-bot @penghuo
fix flakytest when tests.locale=tr (#1827) (#1839)
4fd6402 
Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 4178c03)

Co-authored-by: Peng Huo <penghuo@gmail.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 11, 2023
@penghuo @MitchellGale
fix flakytest when tests.locale=tr (opensearch-project#1827)
43fbadc 
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 11, 2023
@penghuo @MitchellGale
fix flakytest when tests.locale=tr (opensearch-project#1827)
189477a 
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jul 20, 2023
@penghuo @MitchellGale
fix flakytest when tests.locale=tr (opensearch-project#1827)
56754ba 
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKsyunz MaxKsyunz MaxKsyunz approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.9 v2.9.0 v2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penghuo @Yury-Fridlyand @MaxKsyunz