Fixed missing underscores in day_of_week doctest #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Wells <matthew.wells@improving.com>
matthewryanwells
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
MaxKsyunz
approved these changes
Jul 19, 2023
forestmvey
approved these changes
Jul 19, 2023
Yury-Fridlyand
approved these changes
Jul 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1885 +/- ##
=========================================
Coverage 97.39% 97.39%
Complexity 4608 4608
=========================================
Files 401 401
Lines 11408 11408
Branches 843 843
=========================================
Hits 11111 11111
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
…roject#1885) Signed-off-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
…roject#1885) Signed-off-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
matthewryanwells
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 20, 2023
…roject#1885) Signed-off-by: Matthew Wells <matthew.wells@improving.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Jul 27, 2023
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 28, 2023
…roject#1885) Signed-off-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the
day_of_weekPPL doctest accidentally calling thedayofweekfunction insteadIssues Resolved
No related issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.