Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest/SQL-CLI API migration to OpenSearch, renaming and version reset #19

Merged
merged 4 commits into from
Apr 26, 2021

Conversation

zhongnansu
Copy link
Member

Description

  1. Migrate sql plugin API from opendistro to opensearch
  2. fix some UT related to the naming change
  3. rename version to 1.0.0
  4. temporarily fix github CI since we don't have opensearch, sql plugin public artifact ready. But this can be refactored by lanuching OpenSearch instance with plugin installed from gradle.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@@ -22,4 +22,4 @@
express or implied. See the License for the specific language governing
permissions and limitations under the License.
"""
__version__ = "1.13.0.0"
__version__ = "1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we are still using four digits? 1.0.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, fixed

@zhongnansu zhongnansu changed the title SQL-CLI API migration to OpenSearch, renaming and version reset Doctest/SQL-CLI API migration to OpenSearch, renaming and version reset Apr 24, 2021
@dai-chen dai-chen merged commit 3aa4ff7 into develop Apr 26, 2021
Yury-Fridlyand pushed a commit that referenced this pull request Aug 19, 2023
 (#1988)

* spotless apply for OpenSearch P1.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Manual spotless changes

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* spotless apply for OpenSearch P2.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* 90 files checked after spotless apply for legacy

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Added checkstyle ignore failures to legacy

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Fixed comma issue

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Revert build.gradle

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants