[Spotless] Applying Google Code Format for core/src/main files #3 #1932

MitchellGale · 2023-08-03T18:08:49Z

Description

This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/planner
core/src/main/java/org/opensearch/sql/storage
core/src/main/java/org/opensearch/sql/utils

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

…ava OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

…re tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

[Spotless] Applying Google Code Format for core/src/main files #3

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

codecov · 2023-08-03T21:44:43Z

Codecov Report

Merging #1932 (db31dcd) into main (b610ce9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1932      +/-   ##
============================================
- Coverage     97.51%   97.51%   -0.01%     
  Complexity     4658     4658              
============================================
  Files           408      408              
  Lines         11934    11930       -4     
  Branches        834      832       -2     
============================================
- Hits          11637    11633       -4     
  Misses          290      290              
  Partials          7        7

Flag	Coverage Δ
sql-engine	`97.51% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...n/java/org/opensearch/sql/planner/PlanContext.java	`100.00% <ø> (ø)`
...a/org/opensearch/sql/planner/SerializablePlan.java	`100.00% <ø> (ø)`
.../org/opensearch/sql/planner/logical/LogicalAD.java	`100.00% <ø> (ø)`
...search/sql/planner/logical/LogicalAggregation.java	`100.00% <ø> (ø)`
...search/sql/planner/logical/LogicalCloseCursor.java	`100.00% <ø> (ø)`
.../opensearch/sql/planner/logical/LogicalDedupe.java	`100.00% <ø> (ø)`
...rg/opensearch/sql/planner/logical/LogicalEval.java	`100.00% <ø> (ø)`
...search/sql/planner/logical/LogicalFetchCursor.java	`100.00% <ø> (ø)`
.../opensearch/sql/planner/logical/LogicalFilter.java	`100.00% <ø> (ø)`
...ensearch/sql/planner/logical/LogicalHighlight.java	`100.00% <ø> (ø)`
... and 70 more

GumpacG · 2023-08-04T14:50:09Z

core/src/main/java/org/opensearch/sql/planner/physical/RemoveOperator.java

-  private final Set<String> nameRemoveList;
+  @Getter private final PhysicalPlan input;
+  @Getter private final Set<ReferenceExpression> removeList;
+  @ToString.Exclude @EqualsAndHashCode.Exclude private final Set<String> nameRemoveList;


How come the multiple annotations are put on one line here while multiple annotations for the function above are left on multiple lines?

You'll have to look at the rules, but I think the idea is that classes aren't indented so the annotations are put above, while functions and class variables are already indented, so it doesn't hurt to indent them more...?

I agree, this becomes unreadable. Looking forward to have exceptions configured for that rule if possible.

Yury-Fridlyand

Please also fix the PR description

core/src/main/java/org/opensearch/sql/planner/optimizer/rule/PushFilterUnderSort.java

core/src/main/java/org/opensearch/sql/planner/physical/NestedOperator.java

Yury-Fridlyand · 2023-08-05T01:59:31Z

core/src/main/java/org/opensearch/sql/planner/physical/RemoveOperator.java

-  private final Set<String> nameRemoveList;
+  @Getter private final PhysicalPlan input;
+  @Getter private final Set<ReferenceExpression> removeList;
+  @ToString.Exclude @EqualsAndHashCode.Exclude private final Set<String> nameRemoveList;


I agree, this becomes unreadable. Looking forward to have exceptions configured for that rule if possible.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

…ensearch-project#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

…ensearch-project#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

…in files #3 (#1932) (#1994) * [Spotless] Applying Google Code Format for core/src/main files #3 (#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add checkstyle ignore Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

MitchellGale and others added 5 commits August 2, 2023 10:07

Applying Google Java code format changes to core/src/main/java/org/op…

21ce5e7

…ensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Ignore on failure for checkstyle in core and added the three spotless…

479d1bd

… fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.j…

a2a633a

…ava OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

spotless apply, fixing include for spotless build.gradle and adding p…

d52b65c

…re tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Merge pull request #314 from Bit-Quill/dev/sl_GoogleJavaFormat3

ae39e70

[Spotless] Applying Google Code Format for core/src/main files #3

MitchellGale requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vmmusings, Swiddis, penghuo, seankao-az, MaxKsyunz, Yury-Fridlyand, anirudha, forestmvey, acarbonetto and GumpacG as code owners August 3, 2023 18:08

MitchellGale mentioned this pull request Aug 3, 2023

[Spotless] Applying Google Code Format for core #5 Bit-Quill/opensearch-project-sql#324

Merged

6 tasks

Merge branch 'main' into integ/sl_GoogleJavaFormat3

5338a54

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

GumpacG previously approved these changes Aug 4, 2023

View reviewed changes

acarbonetto previously approved these changes Aug 4, 2023

View reviewed changes

MitchellGale mentioned this pull request Aug 5, 2023

Use spotless stylecheck in sql project #1101

Closed

Yury-Fridlyand previously approved these changes Aug 5, 2023

View reviewed changes

addressed PR comments.

2cd9f69

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

MitchellGale dismissed stale reviews from Yury-Fridlyand, acarbonetto, and GumpacG via 2cd9f69 August 5, 2023 05:07

MitchellGale mentioned this pull request Aug 5, 2023

[Spotless] Applying Google Code Format for core #5 #1938

Closed

6 tasks

GumpacG previously approved these changes Aug 8, 2023

View reviewed changes

MitchellGale mentioned this pull request Aug 8, 2023

[Spotless] Applying Google Code Format for core #5 #1942

Closed

6 tasks

Yury-Fridlyand previously approved these changes Aug 8, 2023

View reviewed changes

Merge branch 'main' into integ/sl_GoogleJavaFormat3

db31dcd

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

MitchellGale dismissed stale reviews from Yury-Fridlyand and GumpacG via db31dcd August 9, 2023 20:08

GumpacG approved these changes Aug 9, 2023

View reviewed changes

Yury-Fridlyand approved these changes Aug 9, 2023

View reviewed changes

Yury-Fridlyand merged commit 9914580 into opensearch-project:main Aug 9, 2023

Yury-Fridlyand deleted the integ/sl_GoogleJavaFormat3 branch August 9, 2023 21:02

MitchellGale mentioned this pull request Aug 9, 2023

[Spotless] Applying Google Code Format for core #5 #1951

Merged

6 tasks

MitchellGale mentioned this pull request Aug 18, 2023

[Backport 2.x] [Spotless] Applying Google Code Format for core #5 (#1951) #1996

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Spotless] Applying Google Code Format for core/src/main files #3 #1932

[Spotless] Applying Google Code Format for core/src/main files #3 #1932

MitchellGale commented Aug 3, 2023 •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading

GumpacG Aug 4, 2023 •

edited

Loading

acarbonetto Aug 4, 2023

Yury-Fridlyand Aug 5, 2023

Yury-Fridlyand left a comment

Yury-Fridlyand Aug 5, 2023

[Spotless] Applying Google Code Format for core/src/main files #3 #1932

[Spotless] Applying Google Code Format for core/src/main files #3 #1932

Conversation

MitchellGale commented Aug 3, 2023 • edited Loading

Description

Issues Resolved

Check List

codecov bot commented Aug 3, 2023 • edited Loading

Codecov Report

GumpacG Aug 4, 2023 • edited Loading

Choose a reason for hiding this comment

acarbonetto Aug 4, 2023

Choose a reason for hiding this comment

Yury-Fridlyand Aug 5, 2023

Choose a reason for hiding this comment

Yury-Fridlyand left a comment

Choose a reason for hiding this comment

Yury-Fridlyand Aug 5, 2023

Choose a reason for hiding this comment

MitchellGale commented Aug 3, 2023 •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading

GumpacG Aug 4, 2023 •

edited

Loading