Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spotless] Applying Google Code Format for integ-tests #10 #1967

Merged
merged 4 commits into from
Aug 16, 2023
Merged

[Spotless] Applying Google Code Format for integ-tests #10 #1967

merged 4 commits into from
Aug 16, 2023

Conversation

MitchellGale
Copy link
Contributor

Description

Spotless apply on integ-test (part 3 of 4 integ-test integration).

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MitchellGale
[Spotless] Applying Google Code Format for integ-tests #10 (#329)
e9ea27e 
* Add spotless apply 33 files.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Address PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* fixing integ test failure.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #1967 (ca7ea54) into main (245c4f8) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1967      +/-   ##
============================================
- Coverage     97.51%   97.51%   -0.01%     
+ Complexity     4657     4656       -1     
============================================
  Files           408      408              
  Lines         11933    11930       -3     
  Branches        829      829              
============================================
- Hits          11637    11634       -3     
  Misses          289      289              
  Partials          7        7
Flag Coverage Δ
sql-engine 97.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@MitchellGale @Yury-Fridlyand
Update integ-test/src/test/java/org/opensearch/sql/correctness/tests/…
1c28bca 
…TestConfigTest.java

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
GumpacG
GumpacG previously approved these changes Aug 16, 2023
View reviewed changes
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/SubqueryIT.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/SubqueryIT.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/SubqueryIT.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/SubqueryIT.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/TermQueryExplainIT.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/TermQueryExplainIT.java Outdated Show resolved Hide resolved
@MitchellGale @GumpacG
Apply suggestions from code review
9d2b176 
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
GumpacG
GumpacG reviewed Aug 16, 2023
View reviewed changes
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/TestConfig.java Outdated Show resolved Hide resolved
@MitchellGale MitchellGale mentioned this pull request Aug 16, 2023
Closed
@MitchellGale @GumpacG
Apply suggestions from code review
ca7ea54 
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@acarbonetto acarbonetto merged commit 491a73b into opensearch-project:main Aug 16, 2023
@acarbonetto acarbonetto deleted the integ/sl_GoogleJavaFormat10 branch August 16, 2023 21:00
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
@MitchellGale @Yury-Fridlyand @GumpacG
[Spotless] Applying Google Code Format for integ-tests #10 (opensearc…
5acf5a5 
…h-project#1967)

* [Spotless] Applying Google Code Format for integ-tests #10 (#329)

* Add spotless apply 33 files.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Address PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* fixing integ test failure.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/correctness/tests/TestConfigTest.java

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GumpacG GumpacG GumpacG left review comments

@acarbonetto acarbonetto acarbonetto approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MitchellGale @GumpacG @Yury-Fridlyand @acarbonetto