Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Spotless] Applying Google Code Format for core/src/main files #2 #1931 #1993

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

MitchellGale
Copy link
Contributor

Description

This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/exception
core/src/main/java/org/opensearch/sql/executor
core/src/main/java/org/opensearch/sql/expression
core/src/main/java/org/opensearch/sql/monitor

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ensearch-project#1931)

* Applied spotless changes to `core/stc/main/.../expression` and more.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Applied all spotless for PR 2 for GJF

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Apply spotless to fix custom fixes.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Remove unused <br>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* ignoring core checkstyle failures.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Addressing PR 2 comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Ran spotless apply

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1993 (9a93473) into 2.x (3f7db81) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1993      +/-   ##
============================================
+ Coverage     97.42%   97.50%   +0.08%     
- Complexity     4646     4657      +11     
============================================
  Files           408      408              
  Lines         11525    11925     +400     
  Branches        835      831       -4     
============================================
+ Hits          11228    11628     +400     
  Misses          290      290              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.50% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...a/org/opensearch/sql/analysis/AnalysisContext.java 100.00% <ø> (ø)
...org/opensearch/sql/analysis/HighlightAnalyzer.java 100.00% <ø> (ø)
...ensearch/sql/analysis/NamedExpressionAnalyzer.java 100.00% <ø> (ø)
.../org/opensearch/sql/analysis/symbol/Namespace.java 100.00% <ø> (ø)
...h/sql/exception/ExpressionEvaluationException.java 100.00% <ø> (ø)
...opensearch/sql/exception/QueryEngineException.java 100.00% <ø> (ø)
...ensearch/sql/exception/SemanticCheckException.java 100.00% <ø> (ø)
.../org/opensearch/sql/executor/ExecutionContext.java 100.00% <ø> (ø)
...main/java/org/opensearch/sql/executor/QueryId.java 100.00% <ø> (ø)
...java/org/opensearch/sql/executor/QueryManager.java 100.00% <ø> (ø)
... and 81 more

@Yury-Fridlyand
Copy link
Collaborator

Please, disable checkstyle and rerun spotless

MitchellGale and others added 2 commits August 21, 2023 08:17
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
acarbonetto
acarbonetto previously approved these changes Aug 21, 2023
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 21, 2023
acarbonetto
acarbonetto previously approved these changes Aug 21, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 21, 2023
acarbonetto
acarbonetto previously approved these changes Aug 22, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit df9a827 into opensearch-project:2.x Aug 22, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport2.x-1931 branch August 22, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants