Rename ODBC driver and DSN name #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
chloe-zh
approved these changes
Apr 23, 2021
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 21, 2023
(#1989) * Spotless apply for legacy pt 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply for legacy pt 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * updated type Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * removed spotless Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add spotless Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * removed extra test Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Dai daichen@amazon.com
Description
Rename ODBC driver name and DSN name from
ODFE SQL ODBCtoOpenSearch SQL ODBC. Tested the artifact with new DSN name on Mac without any issue. Because there is no OpenSearch Windows artifact available for now, only DSN name after installation on Windows is verified.TODO: Need another PR to update screenshot in user docs later
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.