Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Run IT tests with security plugin (#335) #1986 #2022

Merged

Conversation

MitchellGale
Copy link
Contributor

@MitchellGale MitchellGale commented Aug 23, 2023

Description

Backport #1986 to 2.x

This PR adds a new IT gradle task: integTestWithSecurity. It starts a cluster with security plugin installed (it takes latest snapshot), configures cluster, http client for tests and runs one test which required to be run with security plugin.
A new GHA is added which runs this test task.

Please, see team review and discussion in Bit-Quill#335.

Issues Resolved

fixes #1713

Check List

New functionality includes testing.

  • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Run IT tests with security plugin (#335)

* Add extra IT flow.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Remove unneeded files.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Fix GHA matrix syntax.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Fix GHA matrix syntax.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Code clean up.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Optimize downloading.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Apply suggestions from code review

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* Update integ-test/build.gradle

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* Typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Rework implementation.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR review.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR feedback + some fixes.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>

* Minor fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Address PR feedback.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Typo fix.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrewc@bitquilltech.com>
(cherry picked from commit 7e3a718)
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2022 (135eb12) into 2.x (c6b37d0) will not change coverage.
Report is 1 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #2022   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
  Complexity     4659     4659           
=========================================
  Files           408      408           
  Lines         12100    12100           
  Branches        830      830           
=========================================
  Hits          11778    11778           
  Misses          315      315           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Yury-Fridlyand Yury-Fridlyand merged commit 280ea22 into opensearch-project:2.x Aug 23, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport/backport-1986-to-2.x branch August 23, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants