Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PPL lang and add datasource to async query API #2187

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Oct 2, 2023

Description

  • Added PPL lang to Async Query API.
  • Added datasource to request model.
  • Removed table and schema tags in non Index Queries.
  • Updated Spark Grammar For Indices.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vmmusings vmmusings force-pushed the enable-ppl-datasource branch from 26dab6c to fc7ec43 Compare October 2, 2023 20:33
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2187 (eb0aabe) into main (ae10857) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##               main    #2187      +/-   ##
============================================
- Coverage     96.56%   96.55%   -0.02%     
+ Complexity     4717     4715       -2     
============================================
  Files           436      436              
  Lines         12535    12526       -9     
  Branches        858      856       -2     
============================================
- Hits          12105    12094      -11     
- Misses          420      422       +2     
  Partials         10       10              
Flag Coverage Δ
sql-engine 96.55% <77.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...park/asyncquery/AsyncQueryExecutorServiceImpl.java 100.00% <100.00%> (ø)
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)
.../sql/spark/rest/model/CreateAsyncQueryRequest.java 22.72% <45.45%> (+22.72%) ⬆️

penghuo
penghuo previously approved these changes Oct 3, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vmmusings vmmusings merged commit ea2ed26 into opensearch-project:main Oct 3, 2023
17 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit ea2ed26)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Oct 3, 2023
(cherry picked from commit ea2ed26)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants