Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add sessionId parameters for create async query API #2323

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8f5e01d from #2312.

* add InteractiveSession and SessionManager

Signed-off-by: Peng Huo <penghuo@gmail.com>

* add statement

Signed-off-by: Peng Huo <penghuo@gmail.com>

* add statement

Signed-off-by: Peng Huo <penghuo@gmail.com>

* fix format

Signed-off-by: Peng Huo <penghuo@gmail.com>

* snapshot

Signed-off-by: Peng Huo <penghuo@gmail.com>

* address comments

Signed-off-by: Peng Huo <penghuo@gmail.com>

* update

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Update REST and Transport interface

Signed-off-by: Peng Huo <penghuo@gmail.com>

* Revert on transport layer

Signed-off-by: Peng Huo <penghuo@gmail.com>

* format code

Signed-off-by: Peng Huo <penghuo@gmail.com>

* add API doc

Signed-off-by: Peng Huo <penghuo@gmail.com>

* modify api

Signed-off-by: Peng Huo <penghuo@gmail.com>

* address comments

Signed-off-by: Peng Huo <penghuo@gmail.com>

* update doc

Signed-off-by: Peng Huo <penghuo@gmail.com>

---------

Signed-off-by: Peng Huo <penghuo@gmail.com>
(cherry picked from commit 8f5e01d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2323 (f34b7fc) into 2.x (9383c7c) will increase coverage by 0.11%.
The diff coverage is 96.73%.

@@             Coverage Diff              @@
##                2.x    #2323      +/-   ##
============================================
+ Coverage     96.62%   96.73%   +0.11%     
- Complexity     4860     4876      +16     
============================================
  Files           455      455              
  Lines         13301    13370      +69     
  Branches        890      899       +9     
============================================
+ Hits          12852    12934      +82     
+ Misses          436      422      -14     
- Partials         13       14       +1     
Flag Coverage Δ
sql-engine 96.73% <96.73%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rch/sql/opensearch/setting/OpenSearchSettings.java 100.00% <100.00%> (ø)
...park/asyncquery/AsyncQueryExecutorServiceImpl.java 100.00% <100.00%> (ø)
...earch/sql/spark/data/constants/SparkConstants.java 0.00% <ø> (ø)
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)
...nsearch/sql/spark/execution/session/SessionId.java 100.00% <100.00%> (ø)
...ch/sql/spark/execution/session/SessionManager.java 100.00% <100.00%> (ø)
...rch/sql/spark/execution/statement/StatementId.java 100.00% <100.00%> (ø)
.../sql/spark/rest/model/CreateAsyncQueryRequest.java 93.54% <90.00%> (+70.82%) ⬆️
.../spark/asyncquery/model/AsyncQueryJobMetadata.java 82.60% <66.66%> (-2.76%) ⬇️

@penghuo penghuo merged commit fbf6143 into 2.x Oct 18, 2023
25 of 28 checks passed
@github-actions github-actions bot deleted the backport/backport-2312-to-2.x branch October 18, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants