-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue in testSourceMetricCommandWithTimestamp integ test with different timezones and locales. #2522
Conversation
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
=========================================
Coverage 95.41% 95.41%
Complexity 5027 5027
=========================================
Files 483 483
Lines 14016 14016
Branches 944 944
=========================================
Hits 13374 13374
Misses 621 621
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bwc tests are unrelated. |
…ferent timezones and locales. (#2522) * Timezon fix Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Timezon fix Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit fcc4be3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ferent timezones and locales. (#2522) * Timezon fix Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> * Timezon fix Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit fcc4be3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ferent timezones and locales. (#2522) (#2523) * Timezon fix * Timezon fix --------- (cherry picked from commit fcc4be3) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ferent timezones and locales. (#2522) (#2524) * Timezon fix * Timezon fix --------- (cherry picked from commit fcc4be3) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
[Describe what this change achieves]
Switched to LocalDateTime for better handling of timezone and locale.
It uses system timezone irrespective of timezone set in JVM using
-Dtests.locale=hi-IN -Dtests.timezone=America/Atka
.Error before fix.
Testing
Following commands worked without error.
Issues Resolved
#1275
#2517
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.