Change the default value of plugins.query.size_limit to MAX_RESULT_WINDOW (10000) #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NDOW (10000) Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
penghuo
approved these changes
Jul 26, 2024
dai-chen
reviewed
Jul 29, 2024
| @@ -90,7 +91,7 @@ public class OpenSearchSettings extends Settings { | |||
| public static final Setting<?> QUERY_SIZE_LIMIT_SETTING = | |||
| Setting.intSetting( | |||
| Key.QUERY_SIZE_LIMIT.getKeyValue(), | |||
| LegacyOpenDistroSettings.QUERY_SIZE_LIMIT_SETTING, | |||
| IndexSettings.MAX_RESULT_WINDOW_SETTING, | |||
There was a problem hiding this comment.
I forgot what does this fallbackSetting argument mean. What's the difference between this and changing the default value 200 in LegacyOpenDistroSettings?
There was a problem hiding this comment.
In don't think we should touch the default value of any LegacyOpenDistroSettings, although the effects are same.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
…NDOW (10000) (#2860) * Change the default value of plugins.query.size_limit to MAX_RESULT_WINDOW (10000) Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix ut Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix spotless Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit aa7a690) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin
pushed a commit
that referenced
this pull request
Aug 1, 2024
…NDOW (10000) (#2860) (#2877) * Change the default value of plugins.query.size_limit to MAX_RESULT_WINDOW (10000) * fix ut * fix spotless --------- (cherry picked from commit aa7a690) Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
to manasvinibs/sql
that referenced
this pull request
Aug 14, 2024
…NDOW (10000) (opensearch-project#2860) * Change the default value of plugins.query.size_limit to MAX_RESULT_WINDOW (10000) Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix ut Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix spotless Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
…NDOW (10000) (opensearch-project#2860) * Change the default value of plugins.query.size_limit to MAX_RESULT_WINDOW (10000) Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix ut Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix spotless Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
plugins.query.size_limitconfigure the maximum amount of rows returned by query. The default value is 200 which inherited from the legacy settingsopendistro.query.size_limit.200is insufficient for many use cases which results incorrect outcomes. Check #2859 for more details.This PR changes the default value of
plugins.query.size_limitto the default value ofindex.max_result_window(10000 by default)Issues Resolved
Resolves #2859
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.