-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push down limit through eval #2876
Conversation
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2876 +/- ##
=========================================
Coverage 94.62% 94.62%
- Complexity 5166 5170 +4
=========================================
Files 508 509 +1
Lines 14539 14559 +20
Branches 959 959
=========================================
+ Hits 13758 13777 +19
- Misses 740 741 +1
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Heng Qian <qianheng@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Thanks for the changes!
core/src/main/java/org/opensearch/sql/planner/optimizer/rule/EvalPushDown.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Heng Qian <qianheng@amazon.com>
core/src/main/java/org/opensearch/sql/planner/optimizer/rule/EvalPushDown.java
Show resolved
Hide resolved
@qianheng-aws could you update the PR title more precise? PR title will be recorded in release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 4a735ea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add a rule EvalPushDown.PUSH_DOWN_LIMIT, this rule will push down limit under eval. Thus, limit has chance to be pushed down into TableScanBuilder later.
e.g.
Note: Also added TODOs in this PR to implement rules PUSH_DOWN_SORT and PUSH_DOWN_PROJECT as follow-ups, which are more complex due to expression replacement.
Related Issues
Resolves #2903
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.