Upgrade org.bouncycastle:bcprov-jdk18on to 1.78.1 #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
penghuo
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
LantaoJin
as code owners
penghuo
added
security fix
derek-ho
reviewed
Sep 10, 2024
datasources/build.gradle
Outdated
| implementation ('com.amazonaws:aws-encryption-sdk-java:2.4.1') { | ||
| exclude group: 'org.bouncycastle', module: 'bcprov-ext-jdk18on' | ||
| } | ||
| implementation 'org.bouncycastle:bcprov-jdk18on:1.78.1' |
There was a problem hiding this comment.
Should we pull version from core instead of hard coding? https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/version.properties#L57
There was a problem hiding this comment.
Do we even need to bring this dependency in? I don't see any usage of it in the repo
There was a problem hiding this comment.
Done. align with core version.
Prometheus datasource use encryption? @vamsi-amazon could u help confirm?
There was a problem hiding this comment.
yes, we are using it for storing basic credentials for prometheus datasource.
derek-ho
previously approved these changes
Sep 10, 2024
Signed-off-by: Peng Huo <penghuo@gmail.com>
vamsimanohar
approved these changes
Sep 11, 2024
dai-chen
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Peng Huo <penghuo@gmail.com> (cherry picked from commit 2506468) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Peng Huo <penghuo@gmail.com> (cherry picked from commit 2506468) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[In OpenSearch 2.16 specifically OpenSearch-SQL, Bouncy Castle is still at version 1.75 and has 4 medium vulnerabilities listed against it in Black Duck:
BDSA-2023-3876/ https://github.com/advisories/GHSA-v435-xc8x-wvr9
BDSA-2024-1960/ https://github.com/advisories/GHSA-8xfc-gm6g-vgpv
BDSA-2023-3876/ https://github.com/advisories/GHSA-v435-xc8x-wvr9
BDSA-2024-2378/ https://github.com/advisories/GHSA-4h8f-2wvx-gg5w]
Related Issues
similar issue. opensearch-project/ml-commons#2903
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.